Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo, crio-o to cri-o #37

Closed
wants to merge 3 commits into from
Closed

Fix typo, crio-o to cri-o #37

wants to merge 3 commits into from

Conversation

mjlshen
Copy link

@mjlshen mjlshen commented Sep 5, 2019

Signed-off-by: Michael Shen [email protected]

@openshift-ci-robot openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Sep 5, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mjlshen
To complete the pull request process, please assign umohnani8
You can assign the PR to them by writing /assign @umohnani8 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2019
@haircommander
Copy link
Member

haircommander commented Sep 5, 2019

LGTM, thanks for the PR @mjlshen ! You'll need to sign off the git commit, by either doing git commit --amend -s via the cli, or adding something like Signed-off-by: $NAME <$EMAIL> manually to the end of the commit

@mjlshen mjlshen changed the title Fix typo, crio-o to cri-o Fix typo, crio-o to cri-oSigned-off-by: Peter Hunt [email protected] Sep 5, 2019
@mjlshen mjlshen changed the title Fix typo, crio-o to cri-oSigned-off-by: Peter Hunt [email protected] Fix typo, crio-o to cri-o Signed-off-by: Michael Shen <[email protected]> Sep 5, 2019
@mjlshen mjlshen changed the title Fix typo, crio-o to cri-o Signed-off-by: Michael Shen <[email protected]> Fix typo, crio-o to cri-o Sep 5, 2019
@openshift-ci-robot
Copy link

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mjlshen
Copy link
Author

mjlshen commented Sep 5, 2019

@haircommander Sorry, I'm kind of new at this, does that seem right?

@haircommander
Copy link
Member

sorry, not quite.
are you working off of the git cli?

@mjlshen
Copy link
Author

mjlshen commented Sep 5, 2019

Yeah, I'm leaning towards just starting over and adding the sign-off to the commit since it's so small

@haircommander
Copy link
Member

that'd work for me :)

@mjlshen mjlshen closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants