Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update minikube href #40

Merged
merged 1 commit into from
Jan 27, 2020
Merged

update minikube href #40

merged 1 commit into from
Jan 27, 2020

Conversation

mattf
Copy link
Contributor

@mattf mattf commented Jan 21, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2020
saschagrunert
saschagrunert approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Collaborator

rhatdan commented Jan 24, 2020

@mattf You need to sign your PR

git commit -a -s --amend
git push --force

@mattf
update minikube href
bde83c6 
Signed-off-by: Matthew Farrellee <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 24, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattf, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@mattf
Copy link
Contributor Author

mattf commented Jan 24, 2020

@rhatdan thanks. i had used github's edit feature to make this patch, which didn't give me an option for signing. #rfe

@rhatdan
Copy link
Collaborator

rhatdan commented Jan 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 29c1684 into cri-o:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattf @rhatdan @openshift-ci-robot @saschagrunert @openshift-merge-robot