Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Ubuntu installation instruction #43

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Apr 20, 2020

Signed-off-by: Slach [email protected]

close #42
I hope DCO exists

@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 20, 2020
@Slach
Copy link
Contributor Author

Slach commented Apr 20, 2020

/assign @haircommander

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2020
@openshift-ci-robot openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 25, 2020
@haircommander
Copy link
Member

you may need to rebase off of master again. the DCO failure is on a merge commit, which shouldn't be included in this PR (it's already merged)

@haircommander
Copy link
Member

thanks for the PR @Slach BTW

@Slach
Copy link
Contributor Author

Slach commented Apr 27, 2020

@haircommander could you suggest me
which git commands should I use to rebase with master?
I tried git pull --rebase upstream master
but bot show me label "dco-commit:no" instead of apply rebase

@haircommander
Copy link
Member

what I do is

git fetch upstream
git rebase upstream/master
git push -f origin ubuntu_install

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 27, 2020
@Slach
Copy link
Contributor Author

Slach commented Apr 27, 2020

@haircommander done, thanks for instruction

@haircommander
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, Slach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 27d49ae into cri-o:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants