Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update installation instructions #45

Merged
merged 1 commit into from
Sep 21, 2020
Merged

update installation instructions #45

merged 1 commit into from
Sep 21, 2020

Conversation

haircommander
Copy link
Member

@haircommander haircommander commented Aug 6, 2020 •
edited
Loading

Signed-off-by: Peter Hunt [email protected]

none

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 6, 2020
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 6, 2020
@haircommander haircommander mentioned this pull request Aug 6, 2020
Closed
@JamesLaverack JamesLaverack mentioned this pull request Sep 20, 2020
Closed
@afbjorklund afbjorklund mentioned this pull request Sep 21, 2020
Closed
@haircommander
Copy link
Member Author

@umohnani8 @mrunalp @saschagrunert @rhatdan @TomSweeneyRedHat PTAL

@haircommander
Copy link
Member Author

fixes cri-o/cri-o#4214 #47

@TomSweeneyRedHat
Copy link
Contributor

LGTM
and apologies for the very tardy review, I somehow missed the initial notification.

@umohnani8
Copy link
Member

LGTM

@haircommander
Copy link
Member Author

can someone /lgtm plz

saschagrunert
saschagrunert approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 34fc577 into cri-o:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haircommander @TomSweeneyRedHat @umohnani8 @openshift-ci-robot @saschagrunert @openshift-merge-robot