Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update available Debian package versions on home page #60

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Update available Debian package versions on home page #60

merged 2 commits into from
Jul 19, 2023

Conversation

dominic-p
Copy link
Contributor

The old versions are not actually available on OBS as of June 2023

See cri-o/cri-o#7072

@openshift-ci openshift-ci bot requested review from mrunalp and rhatdan June 30, 2023 07:42
@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 30, 2023
@haircommander
Copy link
Member

@dominic-p thanks! can you sign-off your PR with git commit --amend -s and then force push it?

@dominic-p
Update available Debian versions
9c917fd 
The old versions are not actually available on OBS as of June 2023

See cri-o/cri-o#7072

Signed-off-by: Dominic <[email protected]>
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 10, 2023
@dominic-p
Copy link
Contributor Author

Since the change was so minor I just made it through the GitHub UI. I guess that doesn't result in a signed commit. Anyway, it should be signed off now. Let me know if there's anything else I should do on this.

@haircommander
Copy link
Member

/lgtm
/approve

thanks!

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@dominic-p
Copy link
Contributor Author

Ok, I added Debian 12, so this should be good to go now.

/release-note-none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 13, 2023
@haircommander
Copy link
Member

/lgtm

mrunalp
mrunalp approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dominic-p, haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 55340d3 into cri-o:master Jul 19, 2023
@dominic-p dominic-p deleted the patch-1 branch July 19, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@mrunalp mrunalp

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominic-p @haircommander @mrunalp @openshift-merge-robot