Fix JvmStatisticsHeap serialization to Parquet (#222)

The class requires to have also the header fields Co-authored-by: William Montaz <[email protected]>
criteo · Oct 24, 2022 · e3ae055 · e3ae055
1 parent ab1f6eb
commit e3ae055
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/readers/hdfs/src/main/java/com/criteo/hadoop/garmadon/hdfs/EventsWithHeader.java b/readers/hdfs/src/main/java/com/criteo/hadoop/garmadon/hdfs/EventsWithHeader.java
@@ -1,6 +1,7 @@
 package com.criteo.hadoop.garmadon.hdfs;
 
 import com.criteo.hadoop.garmadon.event.proto.*;
+import com.criteo.hadoop.garmadon.hdfs.proto.JVMStatisticsExplodedProtos;
 import com.criteo.hadoop.garmadon.protobuf.ProtoConcatenator;
 import com.google.protobuf.Descriptors;
 import com.google.protobuf.DynamicMessage;
@@ -20,9 +21,9 @@ public static Descriptors.Descriptor getDescriptor() throws Descriptors.Descript
         }
     }
 
-    public static abstract class JvmStatsEvent implements Message {
+    public static abstract class JvmStatisticsHeap implements Message {
         public static Descriptors.Descriptor getDescriptor() throws Descriptors.DescriptorValidationException {
-            return descriptorForTypeWithHeader(JVMStatisticsEventsProtos.JVMStatisticsData.getDescriptor());
+            return descriptorForTypeWithHeader(JVMStatisticsExplodedProtos.JvmStatisticsHeap.getDescriptor());
         }
     }
 

diff --git a/readers/hdfs/src/main/java/com/criteo/hadoop/garmadon/hdfs/ReaderFactory.java b/readers/hdfs/src/main/java/com/criteo/hadoop/garmadon/hdfs/ReaderFactory.java
@@ -128,7 +128,7 @@ private static void addJvmStatHeapMessage(Map<Integer, GarmadonEventDescriptor>
             out,
             GarmadonSerialization.TypeMarker.JVMSTATS_EVENT,
                 "jvmstats_heap_event",
-            JVMStatisticsExplodedProtos.JvmStatisticsHeap.class,
+            EventsWithHeader.JvmStatisticsHeap.class,
             JVMStatisticsExplodedProtos.JvmStatisticsHeap.newBuilder(),
             body -> {
                 JVMStatisticsEventsProtos.JVMStatisticsData jvmStatisticsData = (JVMStatisticsEventsProtos.JVMStatisticsData) body;