Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] [ADD] Swift Package Manager Support #345

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

mflknr
Copy link

@mflknr mflknr commented Jan 7, 2025

Hello,

this PR tries to add SPM support in addition to CocoaPods since these are in maintenance mode. The source code compiles and works (as far as i can tell), but I hit a few roadblocks where I figured to ask for some guidance.

  1. The public headers: The podspecs defines the "Public" folder as the path where the public headers are located. Yet, in libraries were Criteo is used with pods, i observed that ALL headers are available and therefor public. The package file seems to be more strict and only makes the header in the "Public" folder public. Thats why I initially said in Swift Package Manager Support #94 that I cannot use the xcframework binary because the headers are not complete. They are complete, but just differently available over pods. It is working now, but I need feedback if everything is semantically correct.
  2. Tests: I had to move some files and therefor targets back and forth because SPM does not support swift/objc mixed targets (which was really bad tbh). The original testplan are no longer working and I cant figure out what was tested there. So someone has recreate the testplans from scratch. We also run into the same problem with the public headers here ...
  3. Automation: Without working testplans, I cant even try to setup fastlane again. So ... there is that.

Anyway, I really need feedback here to continue on this. Thanks.

Closes #94

@mflknr mflknr requested a review from a team as a code owner January 7, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift Package Manager Support
1 participant