feat: Initial implementation of dataset versioning #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjanovsky
requested changes
Oct 26, 2023
There was a problem hiding this comment.
I briefly reviewed this and it looks OK. I guess tests need to change as well. We should also add a new test and check if the warning was issued. I'd like to add two types of warnings:
- Just some note in case the release matches and there's some post-version mismatch
- Real warning when the release of the dataset is older than the release of the tool (or vice versa).
|
Hey all, what is the status of this? Seems quite stale? A rebase would help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.