New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set Ready for resources that miss status.conditions - second attempt #33

Draft

tomaszkiewicz wants to merge 3 commits into crossplane-contrib:main from descant-cloud:main

tomaszkiewicz commented Jul 28, 2024

Description of your changes

Fixes #29 @reedjosh

This is a second attempt, that uses function input to specify GVKs that should have forced readiness.

Sample usage:

- functionRef
    name: function-auto-ready
  input:
    apiVersion: auto-ready.fn.crossplane.io/v1beta1
    kind: Input
    forceReady:
    - kind: ProviderConfig # you can also specify apiVersion, but without that it does "magic" to all ProviderConfigs
    - kind: EnvironmentConfig

I have:

Read and followed Crossplane's contribution process.
Added or updated unit tests for my change.

tomaszkiewicz added 3 commits

July 20, 2024 08:59


          fix: set Ready for resources that miss status.conditions

2c5b692

Signed-off-by: Lukasz Tomaszkiewicz <[email protected]>


          feat: add input for the function that allows specifying for which GVK…

4ab9d8a

… the function should force readiness


          Fix setting condition only if status field is defined

9da8230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet