Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set Ready for resources that miss status.conditions - second attempt #33

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: set Ready for resources that miss status.conditions - second attempt #33

wants to merge 3 commits into from

Conversation

tomaszkiewicz
Copy link

Description of your changes

Fixes #29 @reedjosh

This is a second attempt, that uses function input to specify GVKs that should have forced readiness.

Sample usage:

- functionRef
    name: function-auto-ready
  input:
    apiVersion: auto-ready.fn.crossplane.io/v1beta1
    kind: Input
    forceReady:
    - kind: ProviderConfig # you can also specify apiVersion, but without that it does "magic" to all ProviderConfigs
    - kind: EnvironmentConfig

I have:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briferz briferz briferz approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Never Ready When Creating Env Config
2 participants
@tomaszkiewicz @briferz