This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Upgrades Go to
1.19
,golang.org/x/tools
tov0.1.12
, andgithub.com/crossplane/terrajet
tov0.4.2
, and then regenerates code withmake generate
.make generate
fails at the latest main branch:System and Go information is below:
make reviewable test
fails but it's been failed on the latest main branch:main
Upgrading
golangci-lint
tov1.49.0
fixes the above errors but it's necessary to fix the configuration and/or lint errors themselves. I think it should be out the scope of this change, so it should be fixed in another change.golangci-lint v1.49.0
Related to crossplane/terrajet#271.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested