Skip to content

Commit

Permalink
Delete reference cloud_storage_config.bucket from Subscription.pubsub…
Browse files Browse the repository at this point in the history 
… resource

Signed-off-by: Fatih Türken <[email protected]>
  • Loading branch information
@turkenf
turkenf committed Feb 19, 2024
1 parent f3c1b80 commit 8242fdf
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 233 deletions.
20 changes: 0 additions & 20 deletions apis/pubsub/v1beta1/zz_generated.deepcopy.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 5 additions & 42 deletions apis/pubsub/v1beta1/zz_generated.resolvers.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 1 addition & 19 deletions apis/pubsub/v1beta1/zz_subscription_types.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions config/pubsub/config.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ func Configure(p *config.Provider) {
Type: "Topic",
}
r.Sensitive.AdditionalConnectionDetailsFn = pubsubConnectionDetails
delete(r.References, "cloud_storage_config.bucket")
})

p.AddResourceConfigurator("google_pubsub_subscription_iam_member", func(r *config.Resource) {
Expand Down
152 changes: 0 additions & 152 deletions package/crds/pubsub.gcp.upbound.io_subscriptions.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -154,82 +154,6 @@ spec:
The bucket must be created by the user. The bucket name
must be without any prefix like "gs://".
type: string
bucketRef:
description: Reference to a Bucket in storage to populate
bucket.
properties:
name:
description: Name of the referenced object.
type: string
policy:
description: Policies for referencing.
properties:
resolution:
default: Required
description: |-
Resolution specifies whether resolution of this reference is required.
The default is 'Required', which means the reconcile will fail if the
reference cannot be resolved. 'Optional' means this reference will be
a no-op if it cannot be resolved.
enum:
- Required
- Optional
type: string
resolve:
description: |-
Resolve specifies when this reference should be resolved. The default
is 'IfNotPresent', which will attempt to resolve the reference only when
the corresponding field is not present. Use 'Always' to resolve the
reference on every reconcile.
enum:
- Always
- IfNotPresent
type: string
type: object
required:
- name
type: object
bucketSelector:
description: Selector for a Bucket in storage to populate
bucket.
properties:
matchControllerRef:
description: |-
MatchControllerRef ensures an object with the same controller reference
as the selecting object is selected.
type: boolean
matchLabels:
additionalProperties:
type: string
description: MatchLabels ensures an object with matching
labels is selected.
type: object
policy:
description: Policies for selection.
properties:
resolution:
default: Required
description: |-
Resolution specifies whether resolution of this reference is required.
The default is 'Required', which means the reconcile will fail if the
reference cannot be resolved. 'Optional' means this reference will be
a no-op if it cannot be resolved.
enum:
- Required
- Optional
type: string
resolve:
description: |-
Resolve specifies when this reference should be resolved. The default
is 'IfNotPresent', which will attempt to resolve the reference only when
the corresponding field is not present. Use 'Always' to resolve the
reference on every reconcile.
enum:
- Always
- IfNotPresent
type: string
type: object
type: object
filenamePrefix:
description: User-provided prefix for Cloud Storage filename.
type: string
Expand Down Expand Up @@ -705,82 +629,6 @@ spec:
The bucket must be created by the user. The bucket name
must be without any prefix like "gs://".
type: string
bucketRef:
description: Reference to a Bucket in storage to populate
bucket.
properties:
name:
description: Name of the referenced object.
type: string
policy:
description: Policies for referencing.
properties:
resolution:
default: Required
description: |-
Resolution specifies whether resolution of this reference is required.
The default is 'Required', which means the reconcile will fail if the
reference cannot be resolved. 'Optional' means this reference will be
a no-op if it cannot be resolved.
enum:
- Required
- Optional
type: string
resolve:
description: |-
Resolve specifies when this reference should be resolved. The default
is 'IfNotPresent', which will attempt to resolve the reference only when
the corresponding field is not present. Use 'Always' to resolve the
reference on every reconcile.
enum:
- Always
- IfNotPresent
type: string
type: object
required:
- name
type: object
bucketSelector:
description: Selector for a Bucket in storage to populate
bucket.
properties:
matchControllerRef:
description: |-
MatchControllerRef ensures an object with the same controller reference
as the selecting object is selected.
type: boolean
matchLabels:
additionalProperties:
type: string
description: MatchLabels ensures an object with matching
labels is selected.
type: object
policy:
description: Policies for selection.
properties:
resolution:
default: Required
description: |-
Resolution specifies whether resolution of this reference is required.
The default is 'Required', which means the reconcile will fail if the
reference cannot be resolved. 'Optional' means this reference will be
a no-op if it cannot be resolved.
enum:
- Required
- Optional
type: string
resolve:
description: |-
Resolve specifies when this reference should be resolved. The default
is 'IfNotPresent', which will attempt to resolve the reference only when
the corresponding field is not present. Use 'Always' to resolve the
reference on every reconcile.
enum:
- Always
- IfNotPresent
type: string
type: object
type: object
filenamePrefix:
description: User-provided prefix for Cloud Storage filename.
type: string
Expand Down

0 comments on commit 8242fdf

Please sign in to comment.