Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump native provider version to 5.28.0 #553

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Bump native provider version to 5.28.0 #553

merged 3 commits into from
Jul 3, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Jul 2, 2024 •
edited
Loading

Description of your changes

Upgraded Terraform provider version to v5.28.0

Fixes #517

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • [ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Breaking CRD schema changes

NAME                                                     SYNCED   READY   EXTERNAL-NAME
                                                          AGE
cryptokeyversion.kms.gcp.upbound.io/key-version-fttest   True     True    projects/official-provider-testing/locations/global/keyRings/keyring-crypto-key-version-fttest/c
ryptoKeys/crypto-key-version-fttest/cryptoKeyVersions/2   9m57s

Successful random tests

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 2, 2024

/test-examples="examples/cloudrun/v1beta1/v2service.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 2, 2024

/test-examples="examples/cloudplatform/v1beta1/serviceaccount.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2024

/test-examples="examples/storage/v1beta2/bucket.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2024

/test-examples="examples/spanner/v1beta2/database.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2024

/test-examples="examples/cloudrun/v1beta2/v2service.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2024

/test-examples="examples/dns/v1beta2/policy.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2024

/test-examples="examples/container/v1beta2/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2024

/test-examples="examples/compute/v1beta2/router.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2024

/test-examples="examples/compute/v1beta1/firewall.yaml"

@turkenf turkenf mentioned this pull request Jul 3, 2024
Closed
mergenci
mergenci approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf. LGTM.

package/crds/accesscontextmanager.gcp.upbound.io_serviceperimeterresources.yaml
@@ -35,8 +35,7 @@ spec:
schema:
openAPIV3Schema:
description: ServicePerimeterResource is the Schema for the ServicePerimeterResources
API. Allows configuring a single GCP resource that should be inside of a
service perimeter.
API. Allows configuring a single GCP resource that should be inside the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out code generation wasn't able to properly handle an HTML code tag in the documentation. IMHO, this is not crucial, but let's be aware of the issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the description by adding a manual configuration, but I agree that these should be handled during code generation: c75257fc75257fc75257f

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2024

/test-examples="examples/cloudrun/v1beta1/v2service.yaml"

@turkenf turkenf merged commit 0fafdeb into crossplane-contrib:main Jul 3, 2024
10 checks passed
@turkenf turkenf deleted the update-tf-provider-5.28.0 branch July 3, 2024 15:32
@JonathanO JonathanO mentioned this pull request Jul 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergenci mergenci mergenci approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for google_storage_bucket resource
2 participants
@turkenf @mergenci