Enable linter analysis cache build phase and run the build tagger before linting #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore linting - Linting is now done in two phases: an initial analysis cache build phase, and then the actual linting phase, to decrease the memory footprint of linting. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
For the initial run of the linter in the CI pipelines, the first phase has consumed ~3.5GB of memory and the second phase has consumed ~7GB of memory. Recording as a reference here... |
|
/test-examples="examples/cloudplatform/v1beta1/serviceaccount.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes
Linting is now done in two phases to decrease the memory footprint of linting:
Please refer to crossplane-contrib/provider-upjet-aws#1217 for further details on the implemented techniques. Please note that I have not attempted to fine tune the parameters in this PR, they are probably too aggressive for the
provider-gcprepo. If linting becomes to long to execute, we can revisit these parameters.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Validated locally by running
GOLANGCI_LINT_CACHE=/tmp/golangci-lint SKIP_LINTER_ANALYSIS=false RUN_BUILDTAGGER=true make lint. Also introduced linter errors and observed that the linter can successfully detect them.