Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Terraform Provider Google v6.16.0 #697

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Upgrade to Terraform Provider Google v6.16.0 #697

wants to merge 2 commits into from

Conversation

rickard-von-essen
Copy link
Contributor

@rickard-von-essen rickard-von-essen commented Jan 16, 2025 •
edited
Loading

Description of your changes

Update the underlaying Terraform Provider Goolge to version 6.16.0.

Depends on #695

TODO:

  • Review and test breaking changes, see TPG - v6 Upgrade Guide
  • Bump provider-upjet-gcp major version?
  • Describe upgrade procedures
  • Review/fix/test google_identityplatform_config
  • Review/test Datastore changes.
  • Check if this fixes any issues

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • N/A Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Executed some sanity check with:

UPTEST_EXAMPLE_LIST="examples/secretmanager/v1beta2/secret.yaml,examples/cloudplatform/v1beta1/serviceaccount.yaml"

[...]
--- PASS: kuttl (49.67s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (48.30s)
PASS
12:33:44 [ OK ] running automated tests

@rickard-von-essen
Update crossplane-runtime to v1.17.0 and upjet to db86f70a1651
086348b 
Add new arg to conversion.RegisterConversions()

github.com/crossplane/crossplane-runtime v1.17.0
github.com/crossplane/upjet v1.4.1-0.20250108142216-db86f70a1651

Signed-off-by: Rickard von Essen <[email protected]>
@rickard-von-essen
Upgrade to Terraform Provider Google v6.16.0
b0afca6 
Initial version that at least passes some sanity checks.

Signed-off-by: Rickard von Essen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar will be requested when the pull request is marked ready for review ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin will be requested when the pull request is marked ready for review sergenyalcin is a code owner

@turkenf turkenf Awaiting requested review from turkenf turkenf will be requested when the pull request is marked ready for review turkenf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rickard-von-essen