Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ActionsRepositoryAccessLevel resource #140

Conversation

pravindahal
Copy link
Collaborator

@pravindahal pravindahal commented Jan 14, 2025

Add ActionsRepositoryAccessLevel resource
ref: https://registry.terraform.io/providers/integrations/github/latest/docs/resources/actions_repository_access_level

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

make reviewable test is failing but make test and make check-diff runs successfully.

I am running on the following:

> go version
go version go1.23.3 darwin/arm64
> make reviewable test
WARN [runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner.  
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive. 
apis/repo/v1alpha1/zz_branch_terraformed.go:87:79: tr.GetName undefined (type *Branch has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get parameters for resource '%q'", tr.GetName())
                                                                                            ^
apis/repo/v1alpha1/zz_branch_terraformed.go:95:84: tr.GetName undefined (type *Branch has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get init parameters for resource '%q'", tr.GetName())
                                                                                                 ^
apis/repo/v1alpha1/zz_branch_terraformed.go:107:120: tr.GetName undefined (type *Branch has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot merge spec.initProvider and spec.forProvider parameters for resource '%q'", tr.GetName())
                                                                                                                                     ^
apis/repo/v1alpha1/zz_branchprotection_terraformed.go:87:79: tr.GetName undefined (type *BranchProtection has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get parameters for resource '%q'", tr.GetName())
                                                                                            ^
apis/repo/v1alpha1/zz_branchprotection_terraformed.go:95:84: tr.GetName undefined (type *BranchProtection has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get init parameters for resource '%q'", tr.GetName())
                                                                                                 ^
apis/repo/v1alpha1/zz_branchprotection_terraformed.go:107:120: tr.GetName undefined (type *BranchProtection has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot merge spec.initProvider and spec.forProvider parameters for resource '%q'", tr.GetName())
                                                                                                                                     ^
apis/repo/v1alpha1/zz_defaultbranch_terraformed.go:87:79: tr.GetName undefined (type *DefaultBranch has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get parameters for resource '%q'", tr.GetName())
                                                                                            ^
apis/repo/v1alpha1/zz_defaultbranch_terraformed.go:95:84: tr.GetName undefined (type *DefaultBranch has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get init parameters for resource '%q'", tr.GetName())
                                                                                                 ^
apis/repo/v1alpha1/zz_defaultbranch_terraformed.go:107:120: tr.GetName undefined (type *DefaultBranch has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot merge spec.initProvider and spec.forProvider parameters for resource '%q'", tr.GetName())
                                                                                                                                     ^
apis/repo/v1alpha1/zz_deploykey_terraformed.go:87:79: tr.GetName undefined (type *DeployKey has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get parameters for resource '%q'", tr.GetName())
                                                                                            ^
apis/repo/v1alpha1/zz_deploykey_terraformed.go:95:84: tr.GetName undefined (type *DeployKey has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get init parameters for resource '%q'", tr.GetName())
                                                                                                 ^
apis/repo/v1alpha1/zz_deploykey_terraformed.go:107:120: tr.GetName undefined (type *DeployKey has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot merge spec.initProvider and spec.forProvider parameters for resource '%q'", tr.GetName())
                                                                                                                                     ^
apis/repo/v1alpha1/zz_environment_terraformed.go:87:79: tr.GetName undefined (type *Environment has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get parameters for resource '%q'", tr.GetName())
                                                                                            ^
apis/repo/v1alpha1/zz_environment_terraformed.go:95:84: tr.GetName undefined (type *Environment has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot get init parameters for resource '%q'", tr.GetName())
                                                                                                 ^
apis/repo/v1alpha1/zz_environment_terraformed.go:107:120: tr.GetName undefined (type *Environment has no field or method GetName) (typecheck)
                return nil, errors.Wrapf(err, "cannot merge spec.initProvider and spec.forProvider parameters for resource '%q'", tr.GetName())
                                                                                                                                     ^
apis/repo/v1alpha1/zz_generated.managed.go:12:19: mg.Status.GetCondition undefined (type BranchStatus has no field or method GetCondition) (typecheck)
        return mg.Status.GetCondition(ct)
                         ^
apis/repo/v1alpha1/zz_generated.managed.go:17:17: mg.Spec.DeletionPolicy undefined (type BranchSpec has no field or method DeletionPolicy) (typecheck)
        return mg.Spec.DeletionPolicy
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:22:17: mg.Spec.ManagementPolicies undefined (type BranchSpec has no field or method ManagementPolicies) (typecheck)
        return mg.Spec.ManagementPolicies
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:27:17: mg.Spec.ProviderConfigReference undefined (type BranchSpec has no field or method ProviderConfigReference) (typecheck)
        return mg.Spec.ProviderConfigReference
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:32:17: mg.Spec.PublishConnectionDetailsTo undefined (type BranchSpec has no field or method PublishConnectionDetailsTo) (typecheck)
        return mg.Spec.PublishConnectionDetailsTo
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:37:17: mg.Spec.WriteConnectionSecretToReference undefined (type BranchSpec has no field or method WriteConnectionSecretToReference) (typecheck)
        return mg.Spec.WriteConnectionSecretToReference
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:42:12: mg.Status.SetConditions undefined (type BranchStatus has no field or method SetConditions) (typecheck)
        mg.Status.SetConditions(c...)
                  ^
apis/repo/v1alpha1/zz_generated.managed.go:47:10: mg.Spec.DeletionPolicy undefined (type BranchSpec has no field or method DeletionPolicy) (typecheck)
        mg.Spec.DeletionPolicy = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:52:10: mg.Spec.ManagementPolicies undefined (type BranchSpec has no field or method ManagementPolicies) (typecheck)
        mg.Spec.ManagementPolicies = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:57:10: mg.Spec.ProviderConfigReference undefined (type BranchSpec has no field or method ProviderConfigReference) (typecheck)
        mg.Spec.ProviderConfigReference = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:62:10: mg.Spec.PublishConnectionDetailsTo undefined (type BranchSpec has no field or method PublishConnectionDetailsTo) (typecheck)
        mg.Spec.PublishConnectionDetailsTo = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:67:10: mg.Spec.WriteConnectionSecretToReference undefined (type BranchSpec has no field or method WriteConnectionSecretToReference) (typecheck)
        mg.Spec.WriteConnectionSecretToReference = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:72:19: mg.Status.GetCondition undefined (type BranchProtectionStatus has no field or method GetCondition) (typecheck)
        return mg.Status.GetCondition(ct)
                         ^
apis/repo/v1alpha1/zz_generated.managed.go:77:17: mg.Spec.DeletionPolicy undefined (type BranchProtectionSpec has no field or method DeletionPolicy) (typecheck)
        return mg.Spec.DeletionPolicy
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:82:17: mg.Spec.ManagementPolicies undefined (type BranchProtectionSpec has no field or method ManagementPolicies) (typecheck)
        return mg.Spec.ManagementPolicies
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:87:17: mg.Spec.ProviderConfigReference undefined (type BranchProtectionSpec has no field or method ProviderConfigReference) (typecheck)
        return mg.Spec.ProviderConfigReference
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:92:17: mg.Spec.PublishConnectionDetailsTo undefined (type BranchProtectionSpec has no field or method PublishConnectionDetailsTo) (typecheck)
        return mg.Spec.PublishConnectionDetailsTo
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:97:17: mg.Spec.WriteConnectionSecretToReference undefined (type BranchProtectionSpec has no field or method WriteConnectionSecretToReference) (typecheck)
        return mg.Spec.WriteConnectionSecretToReference
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:102:12: mg.Status.SetConditions undefined (type BranchProtectionStatus has no field or method SetConditions) (typecheck)
        mg.Status.SetConditions(c...)
                  ^
apis/repo/v1alpha1/zz_generated.managed.go:107:10: mg.Spec.DeletionPolicy undefined (type BranchProtectionSpec has no field or method DeletionPolicy) (typecheck)
        mg.Spec.DeletionPolicy = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:112:10: mg.Spec.ManagementPolicies undefined (type BranchProtectionSpec has no field or method ManagementPolicies) (typecheck)
        mg.Spec.ManagementPolicies = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:117:10: mg.Spec.ProviderConfigReference undefined (type BranchProtectionSpec has no field or method ProviderConfigReference) (typecheck)
        mg.Spec.ProviderConfigReference = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:122:10: mg.Spec.PublishConnectionDetailsTo undefined (type BranchProtectionSpec has no field or method PublishConnectionDetailsTo) (typecheck)
        mg.Spec.PublishConnectionDetailsTo = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:127:10: mg.Spec.WriteConnectionSecretToReference undefined (type BranchProtectionSpec has no field or method WriteConnectionSecretToReference) (typecheck)
        mg.Spec.WriteConnectionSecretToReference = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:132:19: mg.Status.GetCondition undefined (type DefaultBranchStatus has no field or method GetCondition) (typecheck)
        return mg.Status.GetCondition(ct)
                         ^
apis/repo/v1alpha1/zz_generated.managed.go:137:17: mg.Spec.DeletionPolicy undefined (type DefaultBranchSpec has no field or method DeletionPolicy) (typecheck)
        return mg.Spec.DeletionPolicy
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:142:17: mg.Spec.ManagementPolicies undefined (type DefaultBranchSpec has no field or method ManagementPolicies) (typecheck)
        return mg.Spec.ManagementPolicies
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:147:17: mg.Spec.ProviderConfigReference undefined (type DefaultBranchSpec has no field or method ProviderConfigReference) (typecheck)
        return mg.Spec.ProviderConfigReference
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:152:17: mg.Spec.PublishConnectionDetailsTo undefined (type DefaultBranchSpec has no field or method PublishConnectionDetailsTo) (typecheck)
        return mg.Spec.PublishConnectionDetailsTo
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:157:17: mg.Spec.WriteConnectionSecretToReference undefined (type DefaultBranchSpec has no field or method WriteConnectionSecretToReference) (typecheck)
        return mg.Spec.WriteConnectionSecretToReference
                       ^
apis/repo/v1alpha1/zz_generated.managed.go:162:12: mg.Status.SetConditions undefined (type DefaultBranchStatus has no field or method SetConditions) (typecheck)
        mg.Status.SetConditions(c...)
                  ^
apis/repo/v1alpha1/zz_generated.managed.go:167:10: mg.Spec.DeletionPolicy undefined (type DefaultBranchSpec has no field or method DeletionPolicy) (typecheck)
        mg.Spec.DeletionPolicy = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:172:10: mg.Spec.ManagementPolicies undefined (type DefaultBranchSpec has no field or method ManagementPolicies) (typecheck)
        mg.Spec.ManagementPolicies = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:177:10: mg.Spec.ProviderConfigReference undefined (type DefaultBranchSpec has no field or method ProviderConfigReference) (typecheck)
        mg.Spec.ProviderConfigReference = r
                ^
apis/repo/v1alpha1/zz_generated.managed.go:182:10: mg.Spec.PublishConnectionDetailsTo undefined (type DefaultBranchSpec has no field or method PublishConnectionDetailsTo) (typecheck)
        mg.Spec.PublishConnectionDetailsTo = r
                ^
16:33:05 [FAIL]

@pravindahal pravindahal force-pushed the pravindahal/feat/add-actionsrepositoryaccesslevel branch from 51ed37c to 42bb846 Compare January 14, 2025 14:27
@xunholy
Copy link
Contributor

xunholy commented Jan 14, 2025

Already proposed in #138

@pravindahal
Copy link
Collaborator Author

Covered by #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants