feat: introduce logging and errors packages #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #22.
I proxied the logging package to it's
crossplane-runtime
counterpart, I felt it was ok to do so because of the small interface the original package has, while I directly vendorederrors
, as it felt already mainly a proxy to the stdliberrors
package and didn't want to add one more indirection layer.I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested