Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce logging and errors packages #31

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

phisco
Copy link
Collaborator

@phisco phisco commented Sep 27, 2023

Description of your changes

Fixes #22.

I proxied the logging package to it's crossplane-runtime counterpart, I felt it was ok to do so because of the small interface the original package has, while I directly vendored errors, as it felt already mainly a proxy to the stdlib errors package and didn't want to add one more indirection layer.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

errors/errors.go Outdated Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
@phisco phisco merged commit 3727afe into crossplane:main Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How should we handle logging and errors?
2 participants