Updates source code for ownership change #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
2 tasks
jeanduplessis
force-pushed
the
ownership_change
branch
2 times, most recently
from
35645e7
to
6b56b8d
Compare
Signed-off-by: Jean du Plessis <[email protected]>
jeanduplessis
force-pushed
the
ownership_change
branch
from
6b56b8d
to
d6c8084
Compare
ulucinar
reviewed
Nov 14, 2023
Comment on lines
+47
to
+48
| - prefix(github.com/crossplane/crossplane-runtime) | ||
| - prefix(github.com/crossplane/crossplane) |
There was a problem hiding this comment.
What we conventionally do is to have the prefixes of the current project in a separate import section, e.g.:
import (
"time"
"github.com/crossplane/crossplane-runtime/pkg/connection"
"github.com/crossplane/crossplane-runtime/pkg/event"
"github.com/crossplane/crossplane-runtime/pkg/ratelimiter"
"github.com/crossplane/crossplane-runtime/pkg/reconciler/managed"
xpresource "github.com/crossplane/crossplane-runtime/pkg/resource"
tjcontroller "github.com/crossplane/upjet/pkg/controller"
"github.com/crossplane/upjet/pkg/controller/handler"
"github.com/crossplane/upjet/pkg/terraform"
ctrl "sigs.k8s.io/controller-runtime"
v1alpha1 "github.com/upbound/upjet-provider-template/apis/null/v1alpha1"
features "github.com/upbound/upjet-provider-template/internal/features"
)
Suggested change
| - prefix(github.com/crossplane/crossplane-runtime) | |
| - prefix(github.com/crossplane/crossplane) | |
| - prefix(github.com/crossplane/upjet-provider-template) |
|
|
||
| skip-files: | ||
| - "zz_\\..+\\.go$" | ||
| - "zz_generated\\..+\\.go$" |
There was a problem hiding this comment.
There are some other generated file names without the zz_generated prefix, such as zz_controller.go or zz_register.go:
Suggested change
| - "zz_generated\\..+\\.go$" | |
| - "zz_\\..+\\.go$" |
| # ==================================================================================== | ||
| # Setup Project | ||
|
|
||
| PROJECT_NAME ?= upjet-provider-template | ||
| PROJECT_REPO ?= github.com/upbound/$(PROJECT_NAME) | ||
| PROJECT_NAME := upjet-provider-template |
There was a problem hiding this comment.
Please see #30 for the rationale behind using ?= instead of :=:
Suggested change
| PROJECT_NAME := upjet-provider-template | |
| PROJECT_NAME ?= upjet-provider-template |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested