Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run the publish-artifacts job last #63

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

tampakrap
Copy link
Contributor

The other jobs are running (lint, unit, functional etc) tests, thus
letting them pass first before publishing any artifacts/images, in order
not to upload broken packages.

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The other jobs are running (lint, unit, functional etc) tests, thus
letting them pass first before publishing any artifacts/images, in order
not to upload broken packages.

Signed-off-by: Theo Chatzimichos <[email protected]>
Copy link
Collaborator

@jeanduplessis jeanduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Thanks

@jeanduplessis jeanduplessis merged commit 65f168d into crossplane:main Apr 5, 2024
8 checks passed
@tampakrap tampakrap deleted the publish_last branch April 6, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants