Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template link in documentation #302

Closed
wants to merge 1 commit into from

Conversation

sanzoghenzo
Copy link

Description of your changes

The first link needed for a beginner to start with the provider generation was broken. It now points to the updated repository location.

I have:

  • Read and followed Upjet's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

The first link needed for a beginner to start with the provider generation was broken.
It now points to the updated repository location.
@sergenyalcin
Copy link
Member

sergenyalcin commented Nov 16, 2023

@sanzoghenzo thanks for this fix. There is a problem about signing-off the commit. The DCO check failed. It seems you successfully signed-off the commit but also the signing-off message must be in the commit message like:

Signed-off-by: Name Mail

@Upbound-CLA
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jeanduplessis
Copy link
Collaborator

Since the template repo is now in the crossplane org this PR is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants