-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade crossplane-runtime to v1.17.0 #437
Upgrade crossplane-runtime to v1.17.0 #437
Conversation
@smcavallo Any on on when you will get an update on this? |
@smcavallo thanks for your contribution 🙏 Can you please rebase onto main? I intend to merge this PR next. |
b427a06
to
fc0d4e8
Compare
524f040
to
fa20c25
Compare
The PR has become a mess, but I've verified that we'll be able to merge it after #451. |
Signed-off-by: smcavallo <[email protected]>
Signed-off-by: smcavallo <[email protected]>
Signed-off-by: smcavallo <[email protected]>
Signed-off-by: smcavallo <[email protected]>
fa20c25
to
bd4838e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smcavallo. LGTM. I consumed this PR in provider-upjet-aws. There were no compile errors, except the fact that clusterauth external client required implementing breaking changes introduced in crossplane-runtime v1.17.0.
Special thanks to @gravufo for their patience, understanding, and support during the long time they had to wait 🙏 Thank you @rickard-von-essen and Daniela for keeping me accountable over Slack. I'm grateful to have members like you in our community 🙏
Signed-off-by: smcavallo [email protected]
Description of your changes
Upgrade crossplane-runtime to v1.17.0 with associated new implementations
See - https://github.com/crossplane/crossplane-runtime/releases/tag/v1.17.0
Implements
Disconnect
onExternalClient
interfaceSee - crossplane/crossplane-runtime#754
Implements
ExternalDelete
return type on methodExternalClient.Delete()
See - crossplane/crossplane-runtime#296
Upgrades go per error below:
go: module github.com/crossplane/[email protected] requires go >= 1.22.0; switching to go1.22.7
When attempting to upgrade an upjet-based provider to
v1.17.0
ofcrossplane-runtime
the below error is generated.This PR should resolve that and allow consumers to upgrade to the newer runtime.
This is a breaking change in that any consumer who uses the newer version of
upjet
will also be forced to upgrade the newer version ofcrossplane-runtime
(and also go >= 1.22.0)Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested