Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade crossplane-runtime to v1.17.0 #437

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

smcavallo
Copy link
Contributor

@smcavallo smcavallo commented Sep 11, 2024

Signed-off-by: smcavallo [email protected]

Description of your changes

Upgrade crossplane-runtime to v1.17.0 with associated new implementations
See - https://github.com/crossplane/crossplane-runtime/releases/tag/v1.17.0

Implements Disconnect on ExternalClient interface
See - crossplane/crossplane-runtime#754

Implements ExternalDelete return type on method ExternalClient.Delete()
See - crossplane/crossplane-runtime#296

Upgrades go per error below:
go: module github.com/crossplane/[email protected] requires go >= 1.22.0; switching to go1.22.7

When attempting to upgrade an upjet-based provider to v1.17.0 of crossplane-runtime the below error is generated.
This PR should resolve that and allow consumers to upgrade to the newer runtime.
This is a breaking change in that any consumer who uses the newer version of upjet will also be forced to upgrade the newer version of crossplane-runtime (and also go >= 1.22.0)

/go/pkg/mod/github.com/crossplane/[email protected]/pkg/controller/external_async_tfpluginfw.go:60:43: impossible type assertion: ec.(*terraformPluginFrameworkExternalClient)
        *terraformPluginFrameworkExternalClient does not implement managed.ExternalClient (wrong type for method Delete)
                have Delete(context.Context, "github.com/crossplane/crossplane-runtime/pkg/resource".Managed) error
                want Delete(context.Context, "github.com/crossplane/crossplane-runtime/pkg/resource".Managed) (managed.ExternalDelete, error)
/go/pkg/mod/github.com/crossplane/[email protected]/pkg/controller/external_async_tfpluginsdk.go:60:9: cannot use &terraformPluginSDKAsyncExternal{…} (value of type *terraformPluginSDKAsyncExternal) as managed.ExternalClient value in return statement: *terraformPluginSDKAsyncExternal does not implement managed.ExternalClient (wrong type for method Delete)
                have Delete(context.Context, "github.com/crossplane/crossplane-runtime/pkg/resource".Managed) error
                want Delete(context.Context, "github.com/crossplane/crossplane-runtime/pkg/resource".Managed) (managed.ExternalDelete, error)

Fixes #

I have:

  • [X ] Read and followed Upjet's contribution process.
  • [X ] Run make reviewable to ensure this PR is ready for review.
  • [X ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@ekarlso
Copy link

ekarlso commented Sep 16, 2024

@smcavallo Any on on when you will get an update on this?

@mergenci
Copy link
Member

mergenci commented Dec 8, 2024

@smcavallo thanks for your contribution 🙏 Can you please rebase onto main? I intend to merge this PR next.

@mergenci mergenci force-pushed the crossplane-runtime_v1.17.0 branch 2 times, most recently from b427a06 to fc0d4e8 Compare December 18, 2024 12:45
@mergenci mergenci force-pushed the crossplane-runtime_v1.17.0 branch 2 times, most recently from 524f040 to fa20c25 Compare December 27, 2024 10:41
@mergenci
Copy link
Member

The PR has become a mess, but I've verified that we'll be able to merge it after #451.

@mergenci mergenci force-pushed the crossplane-runtime_v1.17.0 branch from fa20c25 to bd4838e Compare January 8, 2025 11:41
Copy link
Member

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smcavallo. LGTM. I consumed this PR in provider-upjet-aws. There were no compile errors, except the fact that clusterauth external client required implementing breaking changes introduced in crossplane-runtime v1.17.0.

Special thanks to @gravufo for their patience, understanding, and support during the long time they had to wait 🙏 Thank you @rickard-von-essen and Daniela for keeping me accountable over Slack. I'm grateful to have members like you in our community 🙏

@mergenci mergenci merged commit db86f70 into crossplane:main Jan 8, 2025
6 checks passed
@smcavallo smcavallo deleted the crossplane-runtime_v1.17.0 branch January 8, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants