Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: remove redundant go version check #3118

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 9, 2024

It's already done by the toolchain with go.mod

@mmetc mmetc added this to the 1.6.3 milestone Jul 9, 2024
@mmetc mmetc requested a review from sabban July 9, 2024 10:58
Copy link

github-actions bot commented Jul 9, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jul 9, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

It's already done by the toolchain with go.mod
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.87%. Comparing base (96a6eec) to head (3a5b8ca).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3118      +/-   ##
==========================================
+ Coverage   49.85%   49.87%   +0.01%     
==========================================
  Files         321      321              
  Lines       37667    37667              
==========================================
+ Hits        18780    18785       +5     
+ Misses      17063    17060       -3     
+ Partials     1824     1822       -2     
Flag Coverage Δ
bats 38.47% <ø> (+0.12%) ⬆️
unit-linux 34.44% <ø> (ø)
unit-windows 29.06% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit aa0c389 into master Jul 9, 2024
17 checks passed
@mmetc mmetc deleted the make-go-version-check branch July 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants