Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: increase delta for flaky float comparison #3122

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 10, 2024

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/fix label Jul 10, 2024
@mmetc mmetc added this to the 1.6.3 milestone Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.72%. Comparing base (f130ce6) to head (1204736).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3122      +/-   ##
==========================================
+ Coverage   49.68%   49.72%   +0.03%     
==========================================
  Files         322      322              
  Lines       37910    37910              
==========================================
+ Hits        18837    18850      +13     
+ Misses      17227    17217      -10     
+ Partials     1846     1843       -3     
Flag Coverage Δ
bats 38.43% <ø> (+0.08%) ⬆️
unit-linux 34.18% <ø> (+0.01%) ⬆️
unit-windows 28.86% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban July 15, 2024 08:03
@mmetc mmetc merged commit 9146383 into master Jul 15, 2024
17 checks passed
@mmetc mmetc deleted the test-float-delta branch July 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants