Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli refact: package 'clicapi', 'clilapi' #3185

Merged
merged 4 commits into from
Aug 26, 2024
Merged

cscli refact: package 'clicapi', 'clilapi' #3185

merged 4 commits into from
Aug 26, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 22, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Aug 22, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 68.67470% with 26 lines in your changes missing coverage. Please review.

Project coverage is 50.97%. Comparing base (89aec7c) to head (9d9e32f).
Report is 2 commits behind head on master.

Files Patch % Lines
cmd/crowdsec-cli/idgen/machineid.go 45.83% 12 Missing and 1 partial ⚠️
cmd/crowdsec-cli/idgen/password.go 64.70% 5 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clilapi/utils.go 76.47% 4 Missing ⚠️
cmd/crowdsec-cli/clilapi/lapi.go 75.00% 1 Missing ⚠️
cmd/crowdsec-cli/dashboard.go 0.00% 1 Missing ⚠️
cmd/crowdsec-cli/support.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3185   +/-   ##
=======================================
  Coverage   50.96%   50.97%           
=======================================
  Files         326      329    +3     
  Lines       38659    38658    -1     
=======================================
+ Hits        19704    19706    +2     
+ Misses      17026    17024    -2     
+ Partials     1929     1928    -1     
Flag Coverage Δ
bats 40.33% <82.60%> (-0.03%) ⬇️
unit-linux 34.15% <0.00%> (-0.01%) ⬇️
unit-windows 28.61% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 9c0422f into master Aug 26, 2024
18 checks passed
@mmetc mmetc deleted the clilapi-capi branch August 26, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants