Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: return an error if cscli dashboard is run within a container #3207

Conversation

LaurenceJJones
Copy link
Contributor

To prevent users from running cscli dashboard within a container it should detect the system and return an error.

Copy link

github-actions bot commented Sep 2, 2024

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Sep 2, 2024

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area cscli

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.04%. Comparing base (0fb6468) to head (37cada9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/dashboard.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3207   +/-   ##
=======================================
  Coverage   51.03%   51.04%           
=======================================
  Files         339      339           
  Lines       38629    38631    +2     
=======================================
+ Hits        19715    19719    +4     
+ Misses      16977    16975    -2     
  Partials     1937     1937           
Flag Coverage Δ
bats 40.34% <0.00%> (-0.02%) ⬇️
unit-linux 34.62% <0.00%> (+0.02%) ⬆️
unit-windows 28.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit 8c0c10c into crowdsecurity:master Sep 2, 2024
17 checks passed
@LaurenceJJones LaurenceJJones deleted the cscli_dashboard_prevent_docker branch September 2, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants