Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if resp is nil in capi metrics and continue #3299

Merged

Conversation

LaurenceJJones
Copy link
Contributor

Fix: #3295

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones LaurenceJJones changed the title enhance: Check if resp is nil in capi metrics and continue fix: Check if resp is nil in capi metrics and continue Oct 25, 2024
@LaurenceJJones
Copy link
Contributor Author

/kind fix
/area local-api

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.64%. Comparing base (d8bc17b) to head (691ecfb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apic_metrics.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3299      +/-   ##
==========================================
+ Coverage   39.27%   42.64%   +3.36%     
==========================================
  Files         480      480              
  Lines       62217    62416     +199     
==========================================
+ Hits        24437    26616    +2179     
+ Misses      35124    33144    -1980     
  Partials     2656     2656              
Flag Coverage Δ
bats 31.57% <0.00%> (+0.14%) ⬆️
unit-linux 34.00% <0.00%> (-0.77%) ⬇️
unit-windows 24.74% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit d00a6a6 into crowdsecurity:master Oct 25, 2024
15 of 17 checks passed
@LaurenceJJones LaurenceJJones deleted the capi_metrics_nil_ref branch October 25, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid memory address or nil pointer dereference
2 participants