Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use clientIP when passing coraza #3322

Merged

Conversation

LaurenceJJones
Copy link
Contributor

Fix: #3245

However, r.RemoteAddr is still the remediation, I dont know if we want to fully drop it 🤷🏻

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind fix
/area appsec

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.48%. Comparing base (5d414f5) to head (fcd2ddb).
Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5d414f5) and HEAD (fcd2ddb). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (5d414f5) HEAD (fcd2ddb)
unit-windows 1 0
bats 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3322       +/-   ##
===========================================
- Coverage   58.55%   34.48%   -24.07%     
===========================================
  Files         351      311       -40     
  Lines       37676    33634     -4042     
===========================================
- Hits        22060    11599    -10461     
- Misses      13724    20894     +7170     
+ Partials     1892     1141      -751     
Flag Coverage Δ
bats ?
unit-linux 34.48% <100.00%> (+0.01%) ⬆️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit b96a7a5 into crowdsecurity:master Nov 15, 2024
17 checks passed
@LaurenceJJones LaurenceJJones deleted the appsec-fix-remote-ip branch November 15, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModSecurity rules errors
2 participants