Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bouncers to share API keys #3323

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

blotus
Copy link
Member

@blotus blotus commented Nov 12, 2024

Fixes #3255.
Also closes #3291 and #3287 as HEAD requests will no longer write anything to the database.

@blotus blotus marked this pull request as draft November 12, 2024 12:10
Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Nov 12, 2024

/kind enhancement
/area local-api

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 62.85714% with 39 lines in your changes missing coverage. Please review.

Project coverage is 58.36%. Comparing base (9067106) to head (f858af9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/middlewares/v1/api_key.go 59.18% 15 Missing and 5 partials ⚠️
cmd/crowdsec-cli/clibouncer/delete.go 60.52% 10 Missing and 5 partials ⚠️
pkg/database/bouncers.go 76.92% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clibouncer/inspect.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3323      +/-   ##
==========================================
- Coverage   58.41%   58.36%   -0.05%     
==========================================
  Files         351      351              
  Lines       37746    37827      +81     
==========================================
+ Hits        22049    22079      +30     
- Misses      13800    13838      +38     
- Partials     1897     1910      +13     
Flag Coverage Δ
bats 41.16% <62.85%> (+0.02%) ⬆️
unit-linux 34.38% <26.66%> (-0.02%) ⬇️
unit-windows 29.66% <34.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus added this to the 1.6.4 milestone Nov 17, 2024
@blotus blotus marked this pull request as ready for review November 17, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants