This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Added Button Base Component #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 18, 2021
MarcelCoding
changed the title
MarcelCoding
suggested changes
Sep 18, 2021
|
Todo: Make new click method. |
MarcelCoding
suggested changes
Sep 18, 2021
|
Then you should use CSS variables because you can change them at runtime scss variables are fixed at build time. |
ClientCrash
changed the base branch from
master
to
issue/260-base-components
MarcelCoding
suggested changes
Oct 14, 2021
Merged
|
LGTM! |
MarcelCoding
suggested changes
Oct 15, 2021
MarcelCoding
suggested changes
Feb 28, 2022
| @@ -0,0 +1,79 @@ | |||
| @import 'theme-colors'; | |||
| button{ | |||
There was a problem hiding this comment.
Format CSS, maybe use scss loop and map.
MarcelCoding
suggested changes
Mar 6, 2022
MarcelCoding
approved these changes
Mar 6, 2022
Tristan-H11
suggested changes
Mar 6, 2022
|
|
||
| import { StyledButtonComponent } from './styled-button.component'; | ||
|
|
||
| describe('StyledButtonComponent', () => { |
There was a problem hiding this comment.
With version 3, we want to encourage the use of unit tests. Some basic tests for the flavors and the "disabled"-property would be nice and won't take much time! :)
Co-authored-by: Marcel <[email protected]>
Co-authored-by: Marcel <[email protected]>
MarcelCoding
approved these changes
Mar 6, 2022
Closed
MarcelCoding
pushed a commit
that referenced
this pull request
Mar 6, 2022
MarcelCoding
pushed a commit
that referenced
this pull request
Mar 6, 2022
Closed
MarcelCoding
pushed a commit
that referenced
this pull request
Mar 14, 2022
Tristan-H11
pushed a commit
that referenced
this pull request
Mar 21, 2022
Tristan-H11
pushed a commit
that referenced
this pull request
Mar 21, 2022
Tristan-H11
pushed a commit
that referenced
this pull request
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Button Base Component
Issue
Closes #279