Build quick fix #141
Open
Build quick fix #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plfLaTeX lamented that longtable.sty can't be found, and toprule control sequence is undefined. Solution was to add packages "longtable" and "booktabs".
This fix in a certain way cancels cryptoparty#116, but it's necessary. The fact is that during making html and epub output all the images are supposed to be directly in chapter folders. Commands that link or copy images don't descent into subdirectories, so images in "assets" folder are not copied to destination. So, there was two ways to fix this: first, to change logic to recursively walk into all subfolders and find all images, and second, to place all images in some uniform way (i.e. only in chapter directories, along with text files). The latter was much more easier to make.
In output files the list was formed as a solid stream of words, without line breaks. One solution is to add two spaces in the end of each line. It's the way to introduce line break when converting from md to other formats. Another solution is to put some punctuation, which is more visual for editing source md. I've chosen the latter.
|
Yuval Adam, I revised my set of patches after rebasing over main tree. These ones are still essential for successfull build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches is the result of consequent eliminating of errors and warnings appeared during building the book in all possible formats (make install).