Update DB Readme #602
Merged
Update DB Readme #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add example of query parameters in a query, mention there are more helper methods available for query, mention preparedstatements are at play crystal-db/crystal-lang#164
✅ Deploy Preview for crystal-book ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Note to self: after this is committed add an example of creating a PreparedStatement... |
docs/database/README.md
Outdated
Comment on lines
79
to
80
| Query parameters are accomplished typically using PreparedStatements under the hood, | ||
| though this can be disabled via a connection string option `prepared_statements=false`. |
There was a problem hiding this comment.
Not sure if that statement is correct. I don't think query parameters are technically tied to prepared statements.
docs/database/README.md
Outdated
| @@ -91,6 +93,16 @@ db.query "select name, age from contacts order by age desc" do |rs| | |||
| end | |||
| ``` | |||
|
|
|||
| You can also use query parameters: | |||
There was a problem hiding this comment.
Query parameters are already mentioned in more depth a couple lines above. It would probably make sense to move the explanation of query parameters to a separate section and reference that from both exec and query sections.
There was a problem hiding this comment.
OK attempted see a147195
straight-shoota
approved these changes
Apr 9, 2022
oprypin
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example of query parameters in a query, mention there are more helper methods available for query, mention preparedstatements are at play (crystal-lang/crystal-db#164).