Add warning about concurrent requests in HTTP::Client
#12527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Sep 26, 2022
src/http/client.cr
Outdated
| @@ -58,6 +58,8 @@ | |||
| # client.close | |||
| # ``` | |||
| # | |||
| # WARNING: The implementation of `HTTP::Client` does not support concurrent requests. | |||
There was a problem hiding this comment.
I think we should start using some terminology for this. I wonder if this could be understood as "don't use two HTTP::Client concurrently".
Maybe something like "A single HTTP::Client instance does not support concurrent requests"
In Go they use the phase "safe for concurrent use by multiple goroutines", so maybe we should use "(un)safe for concurrent use by multiple fibers", something like that.
asterite
approved these changes
Sep 27, 2022
sdogruyol
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #12412