Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add crystal tool dependencies #13631

Merged
merged 7 commits into from
Sep 27, 2023

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jul 4, 2023

This is a PR for a feature branch adding the crystal tool dependencies command.

Resolves #11481

@straight-shoota straight-shoota self-assigned this Jul 4, 2023
@straight-shoota straight-shoota changed the title Add crystal tool dependencies Feature: Add crystal tool dependencies Jul 4, 2023
straight-shoota and others added 2 commits August 14, 2023 23:38
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Caspian Baska <[email protected]>
@straight-shoota straight-shoota marked this pull request as ready for review September 8, 2023 14:42
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor and pretty much ignorable comment.

EDIT: as mentioned privately, I haven't checked the autocomplete files

src/compiler/crystal/command.cr Show resolved Hide resolved
output_format = f
if dependencies
opts.on("-f tree|flat|dot|mermaid", "--format tree|flat|dot|mermaid", "Output format tree (default), flat, dot, or mermaid") do |f|
dependency_output_format = DependencyPrinter::Format.parse?(f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this is the below mentioned above)

@straight-shoota straight-shoota added this to the 1.10.0 milestone Sep 25, 2023
@straight-shoota straight-shoota merged commit 09d71d4 into master Sep 27, 2023
106 checks passed
@straight-shoota straight-shoota deleted the feature/tool-dependencies branch September 27, 2023 08:27
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Co-authored-by: Quinton Miller <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Caspian Baska <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crystal tool dependencies: Displaying compile-time source dependencies
2 participants