make: Add generate_data target for running generator scripts
#13700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
reviewed
Jul 24, 2023
|
I think it should be possible to have that working on Windows with a copy of tzdata. |
|
By the way, if we want to avoid tzdata entirely, the standard abbreviation names are also in CLDR, like this: https://github.com/unicode-org/cldr/blob/b24157695397c4c3d2d058c201da92d10c9d9022/common/main/en_NZ.xml#L165 |
HertzDevil
requested changes
Sep 20, 2023
HertzDevil
approved these changes
Sep 20, 2023
straight-shoota
changed the title
generate_data target for running generator scriptsgenerate_data target for running generator scripts
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This target makes it easy to run all generator scripts at once. I want to add this as a check to the release process.