Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libiconv build on Windows #15095

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Fix libiconv build on Windows #15095

merged 1 commit into from
Oct 19, 2024

Conversation

HertzDevil
Copy link
Contributor

  • Do not export symbols from the executable when linking against the static library.
  • Build in release mode.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:text labels Oct 18, 2024
@straight-shoota straight-shoota added this to the 1.15.0 milestone Oct 18, 2024
@straight-shoota straight-shoota merged commit 796a0d2 into crystal-lang:master Oct 19, 2024
67 of 68 checks passed
@HertzDevil HertzDevil deleted the bug/windows-libiconv branch October 20, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:text
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota