Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect constant initializers with mutex on Windows #15134

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Protect constant initializers with mutex on Windows #15134

merged 2 commits into from
Oct 31, 2024

Conversation

HertzDevil
Copy link
Contributor

Fixes #15029.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:runtime kind:regression Something that used to correctly work but no longer works labels Oct 29, 2024
@straight-shoota straight-shoota added this to the 1.15.0 milestone Oct 29, 2024
@straight-shoota straight-shoota merged commit 4aac6f2 into crystal-lang:master Oct 31, 2024
68 of 69 checks passed
@HertzDevil HertzDevil deleted the bug/win32-const-mt branch October 31, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:runtime
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

CI failure: Recursion while initializing class variables and/or constants
2 participants
@HertzDevil @straight-shoota