Use top_level_semantic in doc spec instead of semantic
#9352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
May 25, 2020
|
The docs generator only needs and uses top level semantic, so the result should be entirely correct. |
|
I'm not sure about the |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
nobodywasishere
suggested changes
Jul 10, 2023
| @@ -77,7 +77,23 @@ def semantic(node : ASTNode, *, warnings = nil, wants_doc = false, flags = nil) | |||
| SemanticResult.new(program, node) | |||
| end | |||
|
|
|||
| def assert_normalize(from, to, flags = nil, *, file = __FILE__, line = __LINE__) | |||
There was a problem hiding this comment.
I don't think this should be removed, it's why CI is failing
straight-shoota
approved these changes
Sep 20, 2023
HertzDevil
reviewed
Dec 12, 2023
HertzDevil
reviewed
Dec 12, 2023
HertzDevil
approved these changes
Dec 12, 2023
straight-shoota
changed the title
top_level_semantic in doc spec instead of semantic
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
top_level_semanticutility methods for compiler spec, and uses this in doc spec.crystal docscommand usestop_level_semantic, so the spec follows it.