Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use http scheme for url #42

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Use http scheme for url #42

merged 3 commits into from
Dec 24, 2023

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Dec 23, 2023

No description provided.

jwoertink
jwoertink approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Sija Sija marked this pull request as draft December 23, 2023 23:31
@Sija
Copy link
Contributor Author

Sija commented Dec 23, 2023

Just noticed that if the Host header is empty we're left with an invalid URL, needs a fixup.

@Sija Sija marked this pull request as ready for review December 23, 2023 23:53
@Sija Sija requested a review from jwoertink December 23, 2023 23:53
jwoertink
jwoertink approved these changes Dec 24, 2023
View reviewed changes
Copy link
Contributor

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwoertink jwoertink merged commit d038d56 into crystal-loot:master Dec 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @jwoertink