Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflowing filename #50

Merged
merged 2 commits into from
May 26, 2024
Merged

Fix overflowing filename #50

merged 2 commits into from
May 26, 2024

Conversation

Sija
Copy link
Contributor

@Sija Sija commented May 23, 2024

Before:

image

After:

image

@straight-shoota
Copy link

This hides part of the file name, and the end of it is usually most relevant. If it's impossible to show the entire path, it would be more helpful to cut off the beginning because it's less relevant.

However, it might also be an option to cause the path to break into multiple lines via word-break: break-all;.

@jwoertink
Copy link
Contributor

Thanks for the update @Sija! It definitely looks nicer, but I see what @straight-shoota is saying too. The part you really want to know is src/http/server/handler.cr. Is that be scrollable? If not, maybe you scroll over and see the rest of the path. Or it could be a <input readonly /> and just stylized to look the same. I'm open to ideas.

Copy link
Contributor Author

@Sija Sija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I've made the filename scrollable.

overflow: hidden;
text-overflow: ellipsis;
width: 100%;
overflow: auto hidden;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this was a thing 😂

@jwoertink jwoertink merged commit ed04897 into crystal-loot:master May 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants