Fine tune coverage

docs/src/project_configuration/testing_config.md

@@ -49,6 +49,13 @@ contract MyContract {
   the [`timeout`](./fuzzing_config.md#timeout) is hit, or the user manually stops execution.
 - **Default**: `true`
 
+### `testViewMethods`
+
+- **Type**: Boolean
+- **Description**: Whether `pure` / `view` functions should be called and tested.
+- **Default**: `true`
+-
+
 ### `testAllContracts`
 
 - **Type**: Boolean
@@ -85,12 +92,6 @@ contract MyContract {
 - **Description**: Enable or disable assertion testing
 - **Default**: `true`
 
-### `testViewMethods`
-
-- **Type**: Boolean
-- **Description**: Whether `pure` / `view` functions should be tested for assertion failures.
-- **Default**: `false`
-
 ### `panicCodeConfig`
 
 - **Type**: Struct

fuzzing/config/config.go

@@ -136,6 +136,9 @@ type TestingConfig struct {
 	// than just the contracts specified in the project configuration's deployment order.
 	TestAllContracts bool `json:"testAllContracts"`
 
+	// TestViewMethods dictates whether constant/pure/view methods should be called and tested.
+	TestViewMethods bool `json:"testViewMethods"`
+
 	// TraceAll describes whether a trace should be attached to each element of a finalized shrunken call sequence,
 	// e.g. when a call sequence triggers a test failure. Test providers may attach execution traces by default,
 	// even if this option is not enabled.
@@ -198,9 +201,6 @@ type AssertionTestingConfig struct {
 	// Enabled describes whether testing is enabled.
 	Enabled bool `json:"enabled"`
 
-	// TestViewMethods dictates whether constant/pure/view methods should be tested.
-	TestViewMethods bool `json:"testViewMethods"`
-
 	// PanicCodeConfig describes the various panic codes that can be enabled and be treated as a "failing case"
 	PanicCodeConfig PanicCodeConfig `json:"panicCodeConfig"`
 }

fuzzing/config/config_defaults.go

@@ -68,13 +68,13 @@ func GetDefaultProjectConfig(platform string) (*ProjectConfig, error) {
 				StopOnFailedTest:             true,
 				StopOnFailedContractMatching: false,
 				StopOnNoTests:                true,
+				TestViewMethods:              true,
 				TestAllContracts:             false,
 				TraceAll:                     false,
 				TargetFunctionSignatures:     []string{},
 				ExcludeFunctionSignatures:    []string{},
 				AssertionTesting: AssertionTestingConfig{
-					Enabled:         true,
-					TestViewMethods: false,
+					Enabled: true,
 					PanicCodeConfig: PanicCodeConfig{
 						FailOnAssertion: true,
 					},

fuzzing/fuzzer.go

@@ -349,7 +349,7 @@ func (f *Fuzzer) AddCompilationTargets(compilations []compilationTypes.Compilati
 				assertionTestMethods, propertyTestMethods, optimizationTestMethods := fuzzingutils.BinTestByType(&contract,
 					f.config.Fuzzing.Testing.PropertyTesting.TestPrefixes,
 					f.config.Fuzzing.Testing.OptimizationTesting.TestPrefixes,
-					f.config.Fuzzing.Testing.AssertionTesting.TestViewMethods)
+					f.config.Fuzzing.Testing.TestViewMethods)
 				contractDefinition.AssertionTestMethods = assertionTestMethods
 				contractDefinition.PropertyTestMethods = propertyTestMethods
 				contractDefinition.OptimizationTestMethods = optimizationTestMethods
@@ -842,7 +842,7 @@ func (f *Fuzzer) Start() error {
 	// If StopOnNoTests is true and there are no test cases, then throw an error
 	if f.config.Fuzzing.Testing.StopOnNoTests && len(f.testCases) == 0 {
 		err = fmt.Errorf("no assertion, property, optimization, or custom tests were found to fuzz")
-		if !f.config.Fuzzing.Testing.AssertionTesting.TestViewMethods {
+		if !f.config.Fuzzing.Testing.TestViewMethods {
 			err = fmt.Errorf("no assertion, property, optimization, or custom tests were found to fuzz and testing view methods is disabled")
 		}
 		f.logger.Error("Failed to start fuzzer", err)

fuzzing/fuzzer_test.go

@@ -136,7 +136,6 @@ func TestAssertionMode(t *testing.T) {
 				config.Fuzzing.Testing.AssertionTesting.PanicCodeConfig.FailOnIncorrectStorageAccess = true
 				config.Fuzzing.Testing.AssertionTesting.PanicCodeConfig.FailOnOutOfBoundsArrayAccess = true
 				config.Fuzzing.Testing.AssertionTesting.PanicCodeConfig.FailOnPopEmptyArray = true
-				config.Fuzzing.Testing.AssertionTesting.TestViewMethods = true
 				config.Fuzzing.Testing.PropertyTesting.Enabled = false
 				config.Fuzzing.Testing.OptimizationTesting.Enabled = false
 				config.Slither.UseSlither = false

fuzzing/fuzzer_worker.go

@@ -248,7 +248,7 @@ func (fw *FuzzerWorker) updateMethods() {
 			// Any non-constant method should be tracked as a state changing method.
 			if method.IsConstant() {
 				// Only track the pure/view method if testing view methods is enabled
-				if fw.fuzzer.config.Fuzzing.Testing.AssertionTesting.TestViewMethods {
+				if fw.fuzzer.config.Fuzzing.Testing.TestViewMethods {
 					fw.pureMethods = append(fw.pureMethods, fuzzerTypes.DeployedContractMethod{Address: contractAddress, Contract: contractDefinition, Method: method})
 				}
 			} else {