Fix lambda bug.

cs125-illinois · Oct 22, 2022 · ed98133 · ed98133
1 parent fe36121
commit ed98133
Show file tree

Hide file tree

Showing 8 changed files with 43 additions and 5 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -18,7 +18,7 @@ allprojects {
 }
 subprojects {
     group = "com.github.cs125-illinois.jeed"
-    version = "2022.10.4"
+    version = "2022.10.5"
     tasks.withType<Test> {
         useJUnitPlatform()
         enableAssertions = true

diff --git a/containerrunner/src/main/resources/edu.illinois.cs.cs125.jeed.containerrunner.version b/containerrunner/src/main/resources/edu.illinois.cs.cs125.jeed.containerrunner.version
@@ -1 +1 @@
-version=2022.10.4
+version=2022.10.5
diff --git a/core/src/main/kotlin/JavaComplexity.kt b/core/src/main/kotlin/JavaComplexity.kt
@@ -159,7 +159,7 @@ class JavaComplexityListener(val source: Source, entry: Map.Entry<String, String
 
     override fun enterLambdaExpression(ctx: JavaParser.LambdaExpressionContext) {
         assert(complexityStack.isNotEmpty())
-        (currentComplexity as MethodComplexity).complexity++
+        currentComplexity.complexity++
     }
 
     override fun enterStatement(ctx: JavaParser.StatementContext) {

diff --git a/core/src/main/resources/edu.illinois.cs.cs125.jeed.core.version b/core/src/main/resources/edu.illinois.cs.cs125.jeed.core.version
@@ -1 +1 @@
-version=2022.10.4
+version=2022.10.5
diff --git a/core/src/test/kotlin/TestJavaComplexity.kt b/core/src/test/kotlin/TestJavaComplexity.kt
@@ -683,4 +683,16 @@ public static IWhichHemisphere create(Position p) {
 }""".trim()
         ).complexity()
     }
+    "should allow top-level lambda methods" {
+        Source.fromJavaSnippet(
+            """
+public interface Modify {
+  int modify(int value);
+}
+public class Modifier {
+  Modify modify = value -> value + 1;
+}
+""".trim()
+        ).complexity()
+    }
 })
diff --git a/core/src/test/kotlin/TestJavaFeatures.kt b/core/src/test/kotlin/TestJavaFeatures.kt
@@ -985,4 +985,18 @@ public static IWhichHemisphere create(Position p) {
             featureMap[FeatureName.ANONYMOUS_CLASSES] shouldBe 3
         }
     }
+    "should allow top-level lambda methods" {
+        Source.fromJavaSnippet(
+            """
+public interface Modify {
+  int modify(int value);
+}
+public class Modifier {
+  Modify modify = value -> value + 1;
+}
+""".trim()
+        ).features().check("") {
+            featureMap[FeatureName.LAMBDA_EXPRESSIONS] shouldBe 1
+        }
+    }
 })
diff --git a/core/src/test/kotlin/TestKotlinComplexity.kt b/core/src/test/kotlin/TestKotlinComplexity.kt
@@ -759,4 +759,16 @@ class Main {
             it.lookupFile("Main.kt") shouldBe 3
         }
     }
+    "should allow top-level lambda methods" {
+        Source.fromKotlinSnippet(
+            """
+fun interface Modify {
+  fun modify(value: Int): Int
+}
+class Modifier {
+  val modify = Modify { value -> value + 1 }
+}
+""".trim()
+        ).complexity()
+    }
 })
diff --git a/server/src/main/resources/edu.illinois.cs.cs125.jeed.server.version b/server/src/main/resources/edu.illinois.cs.cs125.jeed.server.version
@@ -1 +1 @@
-version=2022.10.4
+version=2022.10.5