Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Export #462

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Data Export #462

merged 2 commits into from
Feb 15, 2024

Conversation

smartspot2
Copy link
Member

The current data export modal is very bare-bones, and does not actually export much information.

This PR intends to overhaul the data export features, enabling coordinators to export data about courses, attendance, students, sections, etc. with a lot of control over what exactly to include in the exported CSV file.

@smartspot2 smartspot2 added enhancement New feature or request main-pr Central PR for a project labels Dec 23, 2023
@smartspot2 smartspot2 self-assigned this Dec 23, 2023
@smartspot2 smartspot2 marked this pull request as draft December 23, 2023 12:04
Copy link

cypress bot commented Dec 23, 2023

Passing run #306 ↗︎

0 78 0 0 Flakiness 0

Details:

Restyle export page, fix various bugs
Project: csm_web Commit: 49b0dca93b
Status: Passed Duration: 02:07 💡
Started: Feb 15, 2024 5:35 AM Ended: Feb 15, 2024 5:37 AM

Review all test suite changes for PR #462 ↗︎

@smartspot2 smartspot2 force-pushed the feat/data-export branch 2 times, most recently from da5807d to cd6fb67 Compare January 28, 2024 01:29
@smartspot2 smartspot2 marked this pull request as ready for review February 1, 2024 04:58
Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some bugs to fix:

  • When section ID is unselected, no data exports
  • When no course is selected, data still generates, but will error on export.

csm_web/scheduler/views/export.py Show resolved Hide resolved
csm_web/scheduler/views/export.py Show resolved Hide resolved
Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me -- no bugs that break the interface anymore, but some QOL changes that would be good to add in my opinion.

@edwardneo edwardneo self-requested a review February 5, 2024 12:00
Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't mean to approve haha.

jacovkim
jacovkim previously approved these changes Feb 15, 2024
Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Add initial query implementations
Remove old data export modal
Add automatic preview refresh, restyle and add tooltip
Rearrange export page sections into one page
Fix section id query bugs, rework cases where no courses are selected
Add additional fields to export types, fix download data with no courses
Add statuses for export page
Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aproof!

Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@jacovkim jacovkim merged commit 49b0dca into master Feb 15, 2024
16 checks passed
@jacovkim jacovkim deleted the feat/data-export branch February 15, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main-pr Central PR for a project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants