Fix pylint/pre-commit configuration #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartspot2
added
bug
Passing run #295 ↗︎
Details:
Review all test suite changes for PR #463 ↗︎ |
|||||||||||||||
smartspot2
force-pushed
the
fix/pylint
branch
from
0270400
to
92aced5
Compare
smartspot2
force-pushed
the
fix/pylint
branch
2 times, most recently
from
6431499
to
174c3e1
Compare
|
Looks good to me too! |
jacovkim
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes in #457,
psycopg2-binaryis no longer installed by default in development systems (it causes a lot of setup issues). However,pylint_djangorequires a working Django backend in order to provide linting, which now errors due to a lack of thepsycopg2package.This PR modifies the pre-commit configuration to run
pylintin Docker instead, as the Docker container has all of the backend dependencies installed. The pre-commit configuration also still had the old--with=devflag, which is now swapped to--with=prod.