Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configure_file for Perl files #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpflanzer
Copy link
Contributor

Solves the problem that the creduce executable was not regenerated
everytime creduce.in changed.

Solves the problem that the creduce executable was not regenerated
everytime creduce.in changed.
@eeide eeide self-assigned this Feb 14, 2018
@eeide
Copy link
Member

eeide commented Feb 14, 2018

Thank you for this patch! I will review it.

@regehr
Copy link
Member

regehr commented Feb 14, 2018

Yes, thanks, this is great. I looked at the changes and see no problems, but my CMake is not strong.

@mpflanzer
Copy link
Contributor Author

Anything blocking this? I ran cmake with and without my changes and got no difference between the two variants if that helps. ;-)

@eeide
Copy link
Member

eeide commented Mar 15, 2018

I am going to make a new release of C-Reduce before I consider this pull request.

@eeide
Copy link
Member

eeide commented Jul 21, 2018

I tried this on my Mac this morning. If I tweak creduce.in in my source tree, a make in my build tree does cause creduce to be regenerated. Yay!

But if I just remove creduce from my build tree, a make does not regenerate it.

I guess this is OK, but it is sort of un-make-like dependency behavior.

I am using CMake 3.11.4.

@regehr
Copy link
Member

regehr commented Jul 21, 2018

Weird. Anyhow this seems like an improvement and it sounds like we should merge.

@mpflanzer
Copy link
Contributor Author

Mhh, ok. I'll try to have a look next week. Maybe that can be fixed as well.

@mpflanzer
Copy link
Contributor Author

At least part of the problem might be a bug in CMake itself. I filed an issue here: https://gitlab.kitware.com/cmake/cmake/issues/18218. I'll keep an eye on it and let you know about it's progress.

Feel free to merge this PR in the meantime if you want. Or we wait until we know more about the outcome of the CMake issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants