Rename methods to be consistent across connection adapters

cspray · Apr 5, 2024 · 32c1fd6 · 32c1fd6
1 parent fa5d4a6
commit 32c1fd6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/AmpPostgresConnectionAdapter.php b/src/AmpPostgresConnectionAdapter.php
@@ -20,7 +20,7 @@ private function __construct(
         private readonly Closure $connectionFactory
     ) {}
 
-    public static function newConnectionFromConfig(ConnectionAdapterConfig $config) : self {
+    public static function fromConnectionConfig(ConnectionAdapterConfig $config) : self {
         return new self(fn() => connect(
             PostgresConfig::fromString(sprintf(
                 'db=%s host=%s port=%d user=%s pass=%s',
@@ -33,7 +33,7 @@ public static function newConnectionFromConfig(ConnectionAdapterConfig $config)
         ));
     }
 
-    public static function existingConnection(PostgresLink $link) : self {
+    public static function fromExistingConnection(PostgresLink $link) : self {
         return new self(fn() => $link);
     }
 

diff --git a/tests/Integration/AmpPostgresConnectionAdapterTest.php b/tests/Integration/AmpPostgresConnectionAdapterTest.php
@@ -22,6 +22,6 @@ protected function executeCountSql(string $table) : int {
     }
 
     protected static function getConnectionAdapter() : ConnectionAdapter {
-        return AmpPostgresConnectionAdapter::newConnectionFromConfig(new PostgresConnectionConfig());
+        return AmpPostgresConnectionAdapter::fromConnectionConfig(new PostgresConnectionConfig());
     }
 }