Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not produce provenance for DL2 if --no-dl2 option is given #259

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

marialainez
Copy link
Collaborator

@marialainez marialainez commented Nov 27, 2023

Fixes issue #225

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0cdb9c2) 81.65% compared to head (1840650) 81.88%.

❗ Current head 1840650 differs from pull request most recent head cb0281e. Consider uploading reports for the commit cb0281e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   81.65%   81.88%   +0.22%     
==========================================
  Files          57       57              
  Lines        4814     4819       +5     
==========================================
+ Hits         3931     3946      +15     
+ Misses        883      873      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then you need to add the --no-dl2 option to the cmd running provprocess in extract_provenance function of closer.py depending on the value of `options.no_dl2

@morcuended morcuended merged commit dde0eb7 into main Nov 27, 2023
4 checks passed
@morcuended morcuended deleted the prov-dl2 branch November 27, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants