Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link of the updated longterm datacheck file in a common directory #273

Merged
merged 19 commits into from
Feb 14, 2024

Conversation

marialainez
Copy link
Collaborator

No description provided.

@marialainez marialainez marked this pull request as draft February 7, 2024 11:45
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56f3a0b) 81.72% compared to head (de41416) 82.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   81.72%   82.06%   +0.34%     
==========================================
  Files          57       57              
  Lines        4864     4884      +20     
==========================================
+ Hits         3975     4008      +33     
+ Misses        889      876      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marialainez marialainez marked this pull request as ready for review February 7, 2024 15:13
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, and possible simplifications

src/osa/scripts/closer.py Outdated Show resolved Hide resolved
src/osa/scripts/closer.py Outdated Show resolved Hide resolved
src/osa/scripts/closer.py Outdated Show resolved Hide resolved
src/osa/scripts/closer.py Outdated Show resolved Hide resolved
src/osa/scripts/closer.py Outdated Show resolved Hide resolved
src/osa/scripts/closer.py Outdated Show resolved Hide resolved
src/osa/paths.py Outdated Show resolved Hide resolved
src/osa/conftest.py Outdated Show resolved Hide resolved
src/osa/paths.py Outdated Show resolved Hide resolved
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go ahead with the merging

@morcuended morcuended merged commit 4aff331 into main Feb 14, 2024
7 checks passed
@morcuended morcuended deleted the link_datacheck branch February 14, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants