-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gain sel tracker #295
Gain sel tracker #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For formatting, I recommend installing the pre commit hook that does it automatically when committing changes.
Please, also reuse functions defined somewhere else to avoid duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @rcervinoucm, I left some more comments
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Please also add small tests to ensure the script at least runs. Something like: def test_gain_selection_webmaker(
run_summary,
merged_run_summary,
drs4_time_calibration_files,
systematic_correction_files,
base_test_dir,
):
output = sp.run(
["gainsel_webmaker", "--test", "-d", "2020-01-17"],
text=True,
stdout=sp.PIPE,
stderr=sp.PIPE,
)
assert output.returncode != 0 |
also add script name to the entry points list of pyproject.toml so becomes executable |
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Co-authored-by: Daniel Morcuende <[email protected]>
Creation of a gain selection webmaker script to track the status of the process