Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix short session times #921

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Fix short session times #921

merged 2 commits into from
Nov 10, 2024

Conversation

Oscariremma
Copy link
Member

@Oscariremma Oscariremma commented Nov 6, 2024

Currently the session timeout for Gamma is 30 min which does not respect what is in the config/ENV.
The cause of this was that EnableRedisHttpSession was called in the code instead of letting spring boot set it up from the config. This caused the spring.session.timeout (and anything under spring.session.*) setting to be ignored. By removing EnableRedisHttpSession we let spring configure it based on spring.session.store-type.

This is enabled by the config and causes conflicts otherwise
@Oscariremma Oscariremma requested a review from Portals as a code owner November 6, 2024 15:18
Copy link
Member

@Portals Portals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@Oscariremma Oscariremma merged commit 3fb580b into main Nov 10, 2024
1 check passed
@Oscariremma Oscariremma deleted the fix-session-timeout branch November 10, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants