New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PAP password encryption #14

Open

darrenstarr wants to merge 1 commit into ctran:master from darrenstarr:master

darrenstarr commented Jan 19, 2018

The PAP password encryption wasn't RFC2865 compliant.

The RFC says :
b1 = MD5(S + RA) c(1) = p1 xor b1
b2 = MD5(S + c(1)) c(2) = p2 xor b2

What was implemented looked nothing like that.


          Fixed PAP password encryption

b9a22e6

Contributor

edysli commented Oct 28, 2019

@darrenstarr Can you provide a unit test for that fix?
I've glanced at RFC 2865 but couldn't find any test vectors for that encryption algorithm.

ctran added the Reviewed label

ctran force-pushed the master branch 3 times, most recently from 67019ad to 5526820 Compare

February 1, 2022 18:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels